From 4230509e805f546091ca2e4f8aa13c22f6efc7a8 Mon Sep 17 00:00:00 2001 From: milo Date: Mon, 14 Feb 2011 20:23:12 +0100 Subject: Check for NULL pointers in string.c --- src/string.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) (limited to 'src') diff --git a/src/string.c b/src/string.c index 33920e6..1959ab6 100644 --- a/src/string.c +++ b/src/string.c @@ -92,7 +92,13 @@ int ssh_string_fill(struct ssh_string_struct *s, const void *data, size_t len) { */ struct ssh_string_struct *ssh_string_from_char(const char *what) { struct ssh_string_struct *ptr = NULL; - size_t len = strlen(what); + size_t len; + + if(what == NULL) { + return NULL; + } + + len = strlen(what); ptr = malloc(4 + len); if (ptr == NULL) { @@ -133,7 +139,7 @@ size_t ssh_string_len(struct ssh_string_struct *s) { char *ssh_string_to_char(struct ssh_string_struct *s) { size_t len; char *new; - if(s==NULL) + if(s==NULL || s->string == NULL) return NULL; len = ntohl(s->size) + 1; new = malloc(len); @@ -164,7 +170,12 @@ void ssh_string_free_char(char *s) { * @return Newly allocated copy of the string, NULL on error. */ struct ssh_string_struct *ssh_string_copy(struct ssh_string_struct *s) { - struct ssh_string_struct *new = malloc(ntohl(s->size) + 4); + struct ssh_string_struct *new; + + if(s == NULL || s->string == NULL) { + return NULL; + } + new = malloc(ntohl(s->size) + 4); if (new == NULL) { return NULL; -- cgit v1.2.3