From e9e8292370ca1090fbb16a4c55d590c88c9d41dd Mon Sep 17 00:00:00 2001 From: Jakub Jelen Date: Wed, 2 Oct 2019 17:01:43 +0200 Subject: packet: On failure, do not use uninitialized crypto Signed-off-by: Jakub Jelen Reviewed-by: Andreas Schneider Reviewed-by: Anderson Toshiyuki Sasaki --- src/packet.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/packet.c b/src/packet.c index 7855866a..dc844830 100644 --- a/src/packet.c +++ b/src/packet.c @@ -1946,6 +1946,8 @@ ssh_packet_set_newkeys(ssh_session session, session->next_crypto->decryptkey, session->next_crypto->decryptIV); if (rc < 0) { + /* On error, make sure it is not used */ + session->next_crypto->used = 0; return SSH_ERROR; } @@ -1954,6 +1956,8 @@ ssh_packet_set_newkeys(ssh_session session, session->next_crypto->encryptkey, session->next_crypto->encryptIV); if (rc < 0) { + /* On error, make sure it is not used */ + session->next_crypto->used = 0; return SSH_ERROR; } -- cgit v1.2.3