aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJakub Jelen <jjelen@redhat.com>2019-12-11 11:28:33 +0100
committerAndreas Schneider <asn@cryptomilk.org>2019-12-23 14:31:32 +0100
commite2841908fbe5a236ab075ac0a13c26af96f5fe64 (patch)
tree1a6431e851731407f02d70bf9d037d71b5070746
parent2892b49a37e742cc6089c87cab6a89340a2e33a4 (diff)
downloadlibssh-e2841908fbe5a236ab075ac0a13c26af96f5fe64.tar.gz
libssh-e2841908fbe5a236ab075ac0a13c26af96f5fe64.tar.xz
libssh-e2841908fbe5a236ab075ac0a13c26af96f5fe64.zip
kex: Avoid always-false comparisons as reported by csbuild
/builds/jjelen/libssh-mirror/src/kex.c:360:17: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] <--[cc] 360 | if (len < 0) { | ^ /builds/jjelen/libssh-mirror/src/kex.c:372:17: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] <--[cc] 372 | if (len < 0) { | ^ Signed-off-by: Jakub Jelen <jjelen@redhat.com> Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
-rw-r--r--src/kex.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/src/kex.c b/src/kex.c
index ae0371b0..056096cb 100644
--- a/src/kex.c
+++ b/src/kex.c
@@ -356,8 +356,8 @@ SSH_PACKET_CALLBACK(ssh_packet_kexinit)
goto error;
}
- len = ssh_hashbufin_add_cookie(session, session->next_crypto->client_kex.cookie);
- if (len < 0) {
+ ok = ssh_hashbufin_add_cookie(session, session->next_crypto->client_kex.cookie);
+ if (ok < 0) {
ssh_set_error(session, SSH_FATAL, "ssh_packet_kexinit: adding cookie failed");
goto error;
}
@@ -368,8 +368,8 @@ SSH_PACKET_CALLBACK(ssh_packet_kexinit)
goto error;
}
- len = ssh_hashbufin_add_cookie(session, session->next_crypto->server_kex.cookie);
- if (len < 0) {
+ ok = ssh_hashbufin_add_cookie(session, session->next_crypto->server_kex.cookie);
+ if (ok < 0) {
ssh_set_error(session, SSH_FATAL, "ssh_packet_kexinit: adding cookie failed");
goto error;
}