diff options
| author | Andreas Schneider <asn@cryptomilk.org> | 2013-07-14 14:42:13 +0200 |
|---|---|---|
| committer | Andreas Schneider <asn@cryptomilk.org> | 2013-07-14 15:02:02 +0200 |
| commit | 831ed08a56060a5cb0008f7bea0339b3aa3adfe1 (patch) | |
| tree | ddfc5a113b1f6793f76302e31d731e48d864c0db | |
| parent | 1467e0782ed8505553bf7d8c3b9a1b9f473bfcde (diff) | |
| download | libssh-831ed08a56060a5cb0008f7bea0339b3aa3adfe1.tar.gz libssh-831ed08a56060a5cb0008f7bea0339b3aa3adfe1.tar.xz libssh-831ed08a56060a5cb0008f7bea0339b3aa3adfe1.zip | |
gssapi: Check return values of buffer functions.
CID #0
| -rw-r--r-- | src/gssapi.c | 18 |
1 files changed, 14 insertions, 4 deletions
diff --git a/src/gssapi.c b/src/gssapi.c index 3b632452..e5040c3d 100644 --- a/src/gssapi.c +++ b/src/gssapi.c @@ -281,7 +281,8 @@ SSH_PACKET_CALLBACK(ssh_packet_userauth_gssapi_token_server){ gss_name_t client_name = GSS_C_NO_NAME; OM_uint32 ret_flags=0; gss_channel_bindings_t input_bindings=GSS_C_NO_CHANNEL_BINDINGS; - //char *name; + int rc; + (void)user; (void)type; @@ -299,7 +300,7 @@ SSH_PACKET_CALLBACK(ssh_packet_userauth_gssapi_token_server){ if (ssh_callbacks_exists(session->server_callbacks, gssapi_accept_sec_ctx_function)){ ssh_string out_token=NULL; - int rc = session->server_callbacks->gssapi_accept_sec_ctx_function(session, + rc = session->server_callbacks->gssapi_accept_sec_ctx_function(session, token, &out_token, session->server_callbacks->userdata); if (rc == SSH_ERROR){ ssh_auth_reply_default(session, 0); @@ -308,8 +309,17 @@ SSH_PACKET_CALLBACK(ssh_packet_userauth_gssapi_token_server){ return SSH_PACKET_USED; } if (ssh_string_len(out_token) != 0){ - buffer_add_u8(session->out_buffer, SSH2_MSG_USERAUTH_GSSAPI_TOKEN); - buffer_add_ssh_string(session->out_buffer,out_token); + rc = buffer_add_u8(session->out_buffer, + SSH2_MSG_USERAUTH_GSSAPI_TOKEN); + if (rc < 0) { + ssh_set_error_oom(session); + return SSH_PACKET_USED; + } + rc = buffer_add_ssh_string(session->out_buffer, out_token); + if (rc < 0) { + ssh_set_error_oom(session); + return SSH_PACKET_USED; + } packet_send(session); ssh_string_free(out_token); } else { |