From 13ece2a2f81dfa1bddffbbe40001e8470060e455 Mon Sep 17 00:00:00 2001 From: Andreas Schneider Date: Thu, 6 Jan 2011 09:48:30 +0100 Subject: messages: Added missing NULL pointer checks. Found by clang-analyzer http://test.libssh.org/clang-analyzer/ --- src/messages.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/messages.c b/src/messages.c index cee97637..48e1acb5 100644 --- a/src/messages.c +++ b/src/messages.c @@ -877,7 +877,7 @@ SSH_PACKET_CALLBACK(ssh_packet_global_request){ msg = ssh_message_new(session); msg->type = SSH_REQUEST_GLOBAL; - if(!strcmp(request, "tcpip-forward")) { + if (request && strcmp(request, "tcpip-forward") == 0) { bind_addr_s = buffer_get_ssh_string(packet); if (bind_addr_s != NULL) { bind_addr = ssh_string_to_char(bind_addr_s); @@ -900,7 +900,7 @@ SSH_PACKET_CALLBACK(ssh_packet_global_request){ } else { ssh_message_reply_default(msg); } - } else if(!strcmp(request, "cancel-tcpip-forward")) { + } else if (request && strcmp(request, "cancel-tcpip-forward") == 0) { bind_addr_s = buffer_get_ssh_string(packet); if (bind_addr_s != NULL) { bind_addr = ssh_string_to_char(bind_addr_s); -- cgit v1.2.3