From eb796b4bbb86fc488cf3d444f36e5f4a3120d959 Mon Sep 17 00:00:00 2001 From: Nikos Mavrogiannopoulos Date: Wed, 18 Apr 2018 09:09:05 +0200 Subject: buffer: Do not call memcpy with null arguments This allows compiling and testing with undefined sanitizer. Signed-off-by: Nikos Mavrogiannopoulos Reviewed-by: Andreas Schneider --- src/buffer.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/buffer.c b/src/buffer.c index 205aa333..89fd0f6d 100644 --- a/src/buffer.c +++ b/src/buffer.c @@ -145,9 +145,11 @@ static int realloc_buffer(struct ssh_buffer_struct *buffer, size_t needed) { if (new == NULL) { return -1; } - memcpy(new, buffer->data,buffer->used); - explicit_bzero(buffer->data, buffer->used); - SAFE_FREE(buffer->data); + if (buffer->used > 0) { + memcpy(new, buffer->data,buffer->used); + explicit_bzero(buffer->data, buffer->used); + SAFE_FREE(buffer->data); + } } else { new = realloc(buffer->data, needed); if (new == NULL) { -- cgit v1.2.3