From 131a0de32e8e41c9152aee07a010342bf073c389 Mon Sep 17 00:00:00 2001
From: Andreas Schneider <asn@cryptomilk.org>
Date: Mon, 8 Oct 2012 20:01:19 +0200
Subject: auth: Make error handling code reachable again.

Found by Coverity.
---
 src/auth.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/auth.c b/src/auth.c
index 29cbf719..28905fd1 100644
--- a/src/auth.c
+++ b/src/auth.c
@@ -566,7 +566,7 @@ int ssh_userauth_try_publickey(ssh_session session,
 
     /* algo */
     str = ssh_string_from_char(pubkey->type_c);
-    if (rc < 0) {
+    if (str == NULL) {
         goto fail;
     }
 
@@ -728,7 +728,7 @@ int ssh_userauth_publickey(ssh_session session,
 
     /* algo */
     str = ssh_string_from_char(privkey->type_c);
-    if (rc < 0) {
+    if (str == NULL) {
         goto fail;
     }
 
@@ -864,7 +864,7 @@ static int ssh_userauth_agent_publickey(ssh_session session,
 
     /* algo */
     str = ssh_string_from_char(pubkey->type_c);
-    if (rc < 0) {
+    if (str == NULL) {
         goto fail;
     }
 
@@ -1388,7 +1388,7 @@ int ssh_userauth_password(ssh_session session,
 
     /* password */
     str = ssh_string_from_char(password);
-    if (rc < 0) {
+    if (str == NULL) {
         goto fail;
     }
 
@@ -1614,7 +1614,7 @@ static int ssh_userauth_kbdint_init(ssh_session session,
     }
 
     str = ssh_string_from_char(submethods);
-    if (rc < 0) {
+    if (str == NULL) {
         goto fail;
     }
 
-- 
cgit v1.2.3