aboutsummaryrefslogtreecommitdiff
path: root/tests/unittests
diff options
context:
space:
mode:
authorJon Simons <jon@jonsimons.org>2017-07-11 19:23:39 -0400
committerAndreas Schneider <asn@cryptomilk.org>2017-07-13 19:35:34 +0200
commita89a67e0085acd19219d80805770149eb7282615 (patch)
tree5d89d08182fd42a035a526168f1d90ffc477e8b5 /tests/unittests
parenta97db12f4f6926a57479bfc67bec63cfe9f1d695 (diff)
downloadlibssh-a89a67e0085acd19219d80805770149eb7282615.tar.gz
libssh-a89a67e0085acd19219d80805770149eb7282615.tar.xz
libssh-a89a67e0085acd19219d80805770149eb7282615.zip
misc: fix error-checking in ssh_analyze_banner
Fix error-checking for `strtoul` in `ssh_analyze_banner`, and enable some tests which demonstrate the fix before-and-after. Signed-off-by: Jon Simons <jon@jonsimons.org> Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
Diffstat (limited to 'tests/unittests')
-rw-r--r--tests/unittests/torture_misc.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/tests/unittests/torture_misc.c b/tests/unittests/torture_misc.c
index 9cbf57f2..f11f4488 100644
--- a/tests/unittests/torture_misc.c
+++ b/tests/unittests/torture_misc.c
@@ -332,12 +332,10 @@ static void torture_ssh_analyze_banner(void **state) {
assert_server_banner_rejected("SSH-2.0-OpenSSH_X.9p1");
/* OpenSSH banners: bogus minor */
- #if 0 /* these don't pass */
reset_banner_test();
assert_server_banner_rejected("SSH-2.0-OpenSSH_5.Yp1");
reset_banner_test();
assert_client_banner_rejected("SSH-2.0-OpenSSH_5.Yp1");
- #endif /* these don't pass */
/* OpenSSH banners: ssh-keyscan(1) */
#if 0 /* these don't pass */