diff options
author | Andreas Schneider <asn@cryptomilk.org> | 2019-10-31 10:40:16 +0100 |
---|---|---|
committer | Andreas Schneider <asn@cryptomilk.org> | 2019-12-09 16:08:03 +0100 |
commit | cb0ccf372e8c5cd4be896dec8fd451265fd73e89 (patch) | |
tree | 4270952901c91f0f2ae4b955f4ee83ba80ea78d3 /src/dh.c | |
parent | 1fa1a467ed2365569665e1177aa4285dc294c9b8 (diff) | |
download | libssh-cb0ccf372e8c5cd4be896dec8fd451265fd73e89.tar.gz libssh-cb0ccf372e8c5cd4be896dec8fd451265fd73e89.tar.xz libssh-cb0ccf372e8c5cd4be896dec8fd451265fd73e89.zip |
SSH-01-010: Improve documentation for fingerprinting functions
Fixes T184
Signed-off-by: Andreas Schneider <asn@cryptomilk.org>
Reviewed-by: Jakub Jelen <jjelen@redhat.com>
Diffstat (limited to 'src/dh.c')
-rw-r--r-- | src/dh.c | 23 |
1 files changed, 13 insertions, 10 deletions
@@ -696,13 +696,16 @@ static char *ssh_get_b64_unpadded(const unsigned char *hash, size_t len) /** * @brief Get a hash as a human-readable hex- or base64-string. * - * This gets an allocated fingerprint hash. It is a hex strings if the given - * hash is a md5 sum. If it is a SHA sum, it will return an unpadded base64 - * strings. Either way, the output is prepended by the hash-type. + * This gets an allocated fingerprint hash. If it is a SHA sum, it will + * return an unpadded base64 strings. If it is a MD5 sum, it will return hex + * string. Either way, the output is prepended by the hash-type. * - * @param type Which sort of hash is given. + * @warning Do NOT use MD5 or SHA1! Those hash functions are being deprecated. * - * @param hash What should be converted to a base64 string. + * @param type Which sort of hash is given, use + * SSH_PUBLICKEY_HASH_SHA256 or better. + * + * @param hash The hash to be converted to fingerprint. * * @param len Length of the buffer to convert. * @@ -769,13 +772,13 @@ char *ssh_get_fingerprint_hash(enum ssh_publickey_hash_type type, /** * @brief Print a hash as a human-readable hex- or base64-string. * - * This function prints hex strings if the given hash is a md5 sum. - * But prints unpadded base64 strings for sha sums. - * Either way, the output is prepended by the hash-type. + * This prints an unpadded base64 strings for SHA sums and hex strings for MD5 + * sum. Either way, the output is prepended by the hash-type. * - * @param type Which sort of hash is given. + * @param type Which sort of hash is given. Use + * SSH_PUBLICKEY_HASH_SHA256 or better. * - * @param hash What should be converted to a base64 string. + * @param hash The hash to be converted to fingerprint. * * @param len Length of the buffer to convert. * |