aboutsummaryrefslogtreecommitdiff
path: root/src/dh.c
diff options
context:
space:
mode:
authorAris Adamantiadis <aris@0xbadc0de.be>2018-10-27 21:27:00 +0200
committerAndreas Schneider <asn@cryptomilk.org>2019-01-24 09:11:30 +0100
commit602a1defea06f0f63d8c6bdd5b164b86dbfdb971 (patch)
tree082cf1dba7d772e29027ac123c70ebaa07801b6b /src/dh.c
parentfd5770973f17f884317e70fddd743bf718227af0 (diff)
downloadlibssh-602a1defea06f0f63d8c6bdd5b164b86dbfdb971.tar.gz
libssh-602a1defea06f0f63d8c6bdd5b164b86dbfdb971.tar.xz
libssh-602a1defea06f0f63d8c6bdd5b164b86dbfdb971.zip
kex: use runtime callbacks (client)
Signed-off-by: Aris Adamantiadis <aris@0xbadc0de.be> Reviewed-by: Jakub Jelen <jjelen@redhat.com> Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
Diffstat (limited to 'src/dh.c')
-rw-r--r--src/dh.c32
1 files changed, 29 insertions, 3 deletions
diff --git a/src/dh.c b/src/dh.c
index cc12fd46..474f52f3 100644
--- a/src/dh.c
+++ b/src/dh.c
@@ -652,6 +652,19 @@ int ssh_dh_build_k(ssh_session session) {
return 0;
}
+static SSH_PACKET_CALLBACK(ssh_packet_client_dh_reply);
+
+static ssh_packet_callback dh_client_callbacks[]= {
+ ssh_packet_client_dh_reply
+};
+
+static struct ssh_packet_callbacks_struct ssh_dh_client_callbacks = {
+ .start = SSH2_MSG_KEXDH_REPLY,
+ .n_callbacks = 1,
+ .callbacks = dh_client_callbacks,
+ .user = NULL
+};
+
/** @internal
* @brief Starts diffie-hellman-group1 key exchange
*/
@@ -680,6 +693,9 @@ int ssh_client_dh_init(ssh_session session){
ssh_string_free(e);
e=NULL;
+ /* register the packet callbacks */
+ ssh_packet_set_callbacks(session, &ssh_dh_client_callbacks);
+
rc = ssh_packet_send(session);
return rc;
error:
@@ -691,11 +707,15 @@ int ssh_client_dh_init(ssh_session session){
return SSH_ERROR;
}
-int ssh_client_dh_reply(ssh_session session, ssh_buffer packet){
+SSH_PACKET_CALLBACK(ssh_packet_client_dh_reply){
ssh_string f;
ssh_string pubkey_blob = NULL;
ssh_string signature = NULL;
int rc;
+ (void)type;
+ (void)user;
+
+ ssh_packet_remove_callbacks(session, &ssh_dh_client_callbacks);
pubkey_blob = ssh_buffer_get_ssh_string(packet);
if (pubkey_blob == NULL){
@@ -740,10 +760,16 @@ int ssh_client_dh_reply(ssh_session session, ssh_buffer packet){
}
rc=ssh_packet_send(session);
+ if (rc == SSH_ERROR) {
+ goto error;
+ }
+
SSH_LOG(SSH_LOG_PROTOCOL, "SSH_MSG_NEWKEYS sent");
- return rc;
+ session->dh_handshake_state = DH_STATE_NEWKEYS_SENT;
+ return SSH_PACKET_USED;
error:
- return SSH_ERROR;
+ session->session_state=SSH_SESSION_STATE_ERROR;
+ return SSH_PACKET_USED;
}
int ssh_make_sessionid(ssh_session session) {