aboutsummaryrefslogtreecommitdiff
path: root/src/bind.c
diff options
context:
space:
mode:
authorAris Adamantiadis <aris@0xbadc0de.be>2014-02-05 21:24:12 +0100
committerAris Adamantiadis <aris@0xbadc0de.be>2014-03-04 09:55:28 +0100
commite99246246b4061f7e71463f8806b9dcad65affa0 (patch)
tree3275b977bbb6e88f34a554ec02d7bbe4c4ccbbd8 /src/bind.c
parentc96e862c0821d4bb0aa2df676c7a8b212cd885b2 (diff)
downloadlibssh-e99246246b4061f7e71463f8806b9dcad65affa0.tar.gz
libssh-e99246246b4061f7e71463f8806b9dcad65affa0.tar.xz
libssh-e99246246b4061f7e71463f8806b9dcad65affa0.zip
security: fix for vulnerability CVE-2014-0017
When accepting a new connection, a forking server based on libssh forks and the child process handles the request. The RAND_bytes() function of openssl doesn't reset its state after the fork, but simply adds the current process id (getpid) to the PRNG state, which is not guaranteed to be unique. This can cause several children to end up with same PRNG state which is a security issue.
Diffstat (limited to 'src/bind.c')
-rw-r--r--src/bind.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/src/bind.c b/src/bind.c
index 8d82d0d4..03d34031 100644
--- a/src/bind.c
+++ b/src/bind.c
@@ -458,6 +458,8 @@ int ssh_bind_accept_fd(ssh_bind sshbind, ssh_session session, socket_t fd){
return SSH_ERROR;
}
}
+ /* force PRNG to change state in case we fork after ssh_bind_accept */
+ ssh_reseed();
return SSH_OK;
}