aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndreas Schneider <asn@cryptomilk.org>2012-10-08 19:43:55 +0200
committerAndreas Schneider <asn@cryptomilk.org>2012-10-09 11:09:34 +0200
commit41269874f51b794ef93e05766df39dee010956f3 (patch)
tree5985b618e2b400030fdefa490347e20c2562f5a9
parent9abe591843b92cc73b8015cc910a058445e4139c (diff)
downloadlibssh-41269874f51b794ef93e05766df39dee010956f3.tar.gz
libssh-41269874f51b794ef93e05766df39dee010956f3.tar.xz
libssh-41269874f51b794ef93e05766df39dee010956f3.zip
packet: Check return values of buffer functions.
Found by Coverity.
-rw-r--r--src/packet.c10
1 files changed, 8 insertions, 2 deletions
diff --git a/src/packet.c b/src/packet.c
index 5e744189..2256f113 100644
--- a/src/packet.c
+++ b/src/packet.c
@@ -375,8 +375,14 @@ error:
int ssh_packet_send_unimplemented(ssh_session session, uint32_t seqnum){
int r;
enter_function();
- buffer_add_u8(session->out_buffer, SSH2_MSG_UNIMPLEMENTED);
- buffer_add_u32(session->out_buffer, htonl(seqnum));
+ r = buffer_add_u8(session->out_buffer, SSH2_MSG_UNIMPLEMENTED);
+ if (r < 0) {
+ return SSH_ERROR;
+ }
+ r = buffer_add_u32(session->out_buffer, htonl(seqnum));
+ if (r < 0) {
+ return SSH_ERROR;
+ }
r = packet_send(session);
leave_function();
return r;