aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndreas Schneider <asn@cryptomilk.org>2012-10-08 20:01:19 +0200
committerAndreas Schneider <asn@cryptomilk.org>2012-10-09 11:09:34 +0200
commit131a0de32e8e41c9152aee07a010342bf073c389 (patch)
tree47eb7e28582a22d73f966c26c51e2f182e886ac1
parent3e93836e8b19fe9adf444961dafbda98fabdee44 (diff)
downloadlibssh-131a0de32e8e41c9152aee07a010342bf073c389.tar.gz
libssh-131a0de32e8e41c9152aee07a010342bf073c389.tar.xz
libssh-131a0de32e8e41c9152aee07a010342bf073c389.zip
auth: Make error handling code reachable again.
Found by Coverity.
-rw-r--r--src/auth.c10
1 files changed, 5 insertions, 5 deletions
diff --git a/src/auth.c b/src/auth.c
index 29cbf719..28905fd1 100644
--- a/src/auth.c
+++ b/src/auth.c
@@ -566,7 +566,7 @@ int ssh_userauth_try_publickey(ssh_session session,
/* algo */
str = ssh_string_from_char(pubkey->type_c);
- if (rc < 0) {
+ if (str == NULL) {
goto fail;
}
@@ -728,7 +728,7 @@ int ssh_userauth_publickey(ssh_session session,
/* algo */
str = ssh_string_from_char(privkey->type_c);
- if (rc < 0) {
+ if (str == NULL) {
goto fail;
}
@@ -864,7 +864,7 @@ static int ssh_userauth_agent_publickey(ssh_session session,
/* algo */
str = ssh_string_from_char(pubkey->type_c);
- if (rc < 0) {
+ if (str == NULL) {
goto fail;
}
@@ -1388,7 +1388,7 @@ int ssh_userauth_password(ssh_session session,
/* password */
str = ssh_string_from_char(password);
- if (rc < 0) {
+ if (str == NULL) {
goto fail;
}
@@ -1614,7 +1614,7 @@ static int ssh_userauth_kbdint_init(ssh_session session,
}
str = ssh_string_from_char(submethods);
- if (rc < 0) {
+ if (str == NULL) {
goto fail;
}