Fix ssh_write_knownhost() which always returned -1.

fwrite() return the the number of items written not the size of the
buffer.

2 files changed, 6 insertions, 4 deletions

diff --git a/libssh/keyfiles.c b/libssh/keyfiles.c
index f944e818..ad456cdf 100644
--- a/libssh/keyfiles.c
+++ b/libssh/keyfiles.c
@@ -1576,7 +1576,7 @@ int ssh_write_knownhost(SSH_SESSION *session) {
   }
 
   len = strlen(buffer);
-  if (fwrite(buffer, len, 1, file) != len || ferror(file)) {
+  if (fwrite(buffer, len, 1, file) != 1 || ferror(file)) {
     fclose(file);
     return -1;
   }
diff --git a/sample.c b/sample.c
index 85ea7d19..e2036914 100644
--- a/sample.c
+++ b/sample.c
@@ -476,7 +476,6 @@ int main(int argc, char **argv){
             /* fallback to SSH_SERVER_NOT_KNOWN behaviour */
         case SSH_SERVER_NOT_KNOWN:
             hexa = ssh_get_hexa(hash, hlen);
-            free(hash);
             fprintf(stderr,"The server is unknown. Do you trust the host key ?\n");
             fprintf(stderr, "Public key hash: %s\n", hexa);
             free(hexa);
@@ -488,8 +487,11 @@ int main(int argc, char **argv){
             fprintf(stderr,"This new key will be written on disk for further usage. do you agree ?\n");
             fgets(buf,sizeof(buf),stdin);
             if(strncasecmp(buf,"yes",3)==0){
-                if(ssh_write_knownhost(session))
-                    fprintf(stderr,"error %s\n",ssh_get_error(session));
+                if (ssh_write_knownhost(session) < 0) {
+                  free(hash);
+                  fprintf(stderr, "error %s\n", strerror(errno));
+                  exit(-1);
+                }
             }
             
             break;