diff options
author | Jakub Jelen <jjelen@redhat.com> | 2019-12-16 16:42:50 +0100 |
---|---|---|
committer | Andreas Schneider <asn@cryptomilk.org> | 2020-01-23 09:49:16 +0100 |
commit | 62f7004d5a349c90a4eed658bb56eaa40857865b (patch) | |
tree | 987aaf7d99b91655d55392b7387341e79807a913 | |
parent | d7358ee5a7104728fd96734cb927ca8f5e38cc42 (diff) | |
download | libssh-62f7004d5a349c90a4eed658bb56eaa40857865b.tar.gz libssh-62f7004d5a349c90a4eed658bb56eaa40857865b.tar.xz libssh-62f7004d5a349c90a4eed658bb56eaa40857865b.zip |
pki_mbedtls: Avoid potential memory leaks
reported by csbuild
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
(cherry picked from commit 059b6851dc0d42ab6bb9dbf7134ce4c30c52ce1f)
-rw-r--r-- | src/pki_mbedcrypto.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/pki_mbedcrypto.c b/src/pki_mbedcrypto.c index ea204d01..64d3a436 100644 --- a/src/pki_mbedcrypto.c +++ b/src/pki_mbedcrypto.c @@ -113,7 +113,7 @@ ssh_key pki_private_key_from_base64(const char *b64_key, const char *passphrase, valid = auth_fn("Passphrase for private key:", (char *) tmp, MAX_PASSPHRASE_SIZE, 0, 0, auth_data); if (valid < 0) { - return NULL; + goto fail; } /* TODO fix signedness and strlen */ valid = mbedtls_pk_parse_key(rsa, @@ -155,7 +155,7 @@ ssh_key pki_private_key_from_base64(const char *b64_key, const char *passphrase, valid = auth_fn("Passphrase for private key:", (char *) tmp, MAX_PASSPHRASE_SIZE, 0, 0, auth_data); if (valid < 0) { - return NULL; + goto fail; } valid = mbedtls_pk_parse_key(ecdsa, (const unsigned char *) b64_key, |