diff options
| author | Andreas Schneider <asn@cryptomilk.org> | 2019-10-31 10:20:00 +0100 |
|---|---|---|
| committer | Andreas Schneider <asn@cryptomilk.org> | 2019-12-09 16:38:37 +0100 |
| commit | 8600015b3e1597f5ce340ffaae9802fe7196f95f (patch) | |
| tree | 30fac9d028259ab95bc1771f6ed67da644d333d8 | |
| parent | 8f20ece14f57310c93488f200cba9b901a3d72a8 (diff) | |
| download | libssh-8600015b3e1597f5ce340ffaae9802fe7196f95f.tar.gz libssh-8600015b3e1597f5ce340ffaae9802fe7196f95f.tar.xz libssh-8600015b3e1597f5ce340ffaae9802fe7196f95f.zip | |
pki: Fix possible information leak via uninitialized stack buffer
Fixes T190
Signed-off-by: Andreas Schneider <asn@cryptomilk.org>
Reviewed-by: Jakub Jelen <jjelen@redhat.com>
(cherry picked from commit 178b53f92434b214e3068e33811690b1227b2e15)
| -rw-r--r-- | src/pki_container_openssh.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/pki_container_openssh.c b/src/pki_container_openssh.c index 4a2c71c6..ecde4cdd 100644 --- a/src/pki_container_openssh.c +++ b/src/pki_container_openssh.c @@ -440,9 +440,9 @@ static int pki_private_key_encrypt(ssh_buffer privkey_buffer, { struct ssh_cipher_struct *ciphers = ssh_get_ciphertab(); struct ssh_cipher_struct cipher; - uint8_t key_material[128]; + uint8_t key_material[128] = {0}; size_t key_material_len; - char passphrase_buffer[128]; + char passphrase_buffer[128] = {0}; int rc; int i; int cmp; |